-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Buildkite command/commands support to yaml injections #10090
Merged
pascalkuthe
merged 2 commits into
helix-editor:master
from
mmlb:add-buildkite-yaml-injections
Apr 2, 2024
Merged
Add Buildkite command/commands support to yaml injections #10090
pascalkuthe
merged 2 commits into
helix-editor:master
from
mmlb:add-buildkite-yaml-injections
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go back to original intent when this code was first written now that the tree-sitter version used supports any-of?.
Buildkite uses `command` (`commands` is an alias) to define the command(s) to run for the step.
the-mikedavis
approved these changes
Apr 1, 2024
the-mikedavis
added
S-waiting-on-review
Status: Awaiting review from a maintainer.
A-language-support
Area: Support for programming/text languages
labels
Apr 1, 2024
Looks like the injection works with circleci too: https://circleci.com/docs/configuration-reference/#run |
pascalkuthe
approved these changes
Apr 2, 2024
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Apr 3, 2024
…or#10090) * Use any-of instead of match in yaml injections Go back to original intent when this code was first written now that the tree-sitter version used supports any-of?. * yaml/injections: Add injection for Buildkite Buildkite uses `command` (`commands` is an alias) to define the command(s) to run for the step.
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
…or#10090) * Use any-of instead of match in yaml injections Go back to original intent when this code was first written now that the tree-sitter version used supports any-of?. * yaml/injections: Add injection for Buildkite Buildkite uses `command` (`commands` is an alias) to define the command(s) to run for the step.
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
…or#10090) * Use any-of instead of match in yaml injections Go back to original intent when this code was first written now that the tree-sitter version used supports any-of?. * yaml/injections: Add injection for Buildkite Buildkite uses `command` (`commands` is an alias) to define the command(s) to run for the step.
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
…or#10090) * Use any-of instead of match in yaml injections Go back to original intent when this code was first written now that the tree-sitter version used supports any-of?. * yaml/injections: Add injection for Buildkite Buildkite uses `command` (`commands` is an alias) to define the command(s) to run for the step.
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
…or#10090) * Use any-of instead of match in yaml injections Go back to original intent when this code was first written now that the tree-sitter version used supports any-of?. * yaml/injections: Add injection for Buildkite Buildkite uses `command` (`commands` is an alias) to define the command(s) to run for the step.
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
…or#10090) * Use any-of instead of match in yaml injections Go back to original intent when this code was first written now that the tree-sitter version used supports any-of?. * yaml/injections: Add injection for Buildkite Buildkite uses `command` (`commands` is an alias) to define the command(s) to run for the step.
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
…or#10090) * Use any-of instead of match in yaml injections Go back to original intent when this code was first written now that the tree-sitter version used supports any-of?. * yaml/injections: Add injection for Buildkite Buildkite uses `command` (`commands` is an alias) to define the command(s) to run for the step.
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
…or#10090) * Use any-of instead of match in yaml injections Go back to original intent when this code was first written now that the tree-sitter version used supports any-of?. * yaml/injections: Add injection for Buildkite Buildkite uses `command` (`commands` is an alias) to define the command(s) to run for the step.
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
…or#10090) * Use any-of instead of match in yaml injections Go back to original intent when this code was first written now that the tree-sitter version used supports any-of?. * yaml/injections: Add injection for Buildkite Buildkite uses `command` (`commands` is an alias) to define the command(s) to run for the step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-language-support
Area: Support for programming/text languages
S-waiting-on-review
Status: Awaiting review from a maintainer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds injection support to yaml for buildkite command steps.